Repository navigation
DirectXUA initialized with a vector of trajectories - #68
Merged
Merged
Conversation
PhilippeMaincon
requested changes
Apr 27, 2026
PhilippeMaincon
left a comment
PhilippeMaincon
left a comment
Collaborator
There was a problem hiding this comment.
I am curious to see whether providing inital trajectories will prove necessary in the long run. Until then, this is a great additional functionality.
See comments in src/DirectXUA.jl
Your new functionality must be tested (test/TestDirectXUA*.jl) with a test that is fast. Re-running an existing multi-experiment test, just changing initialstate to initialtrajectory will work with very little or no recompilation, making the additional test very fast.
PhilippeMaincon
approved these changes
Jul 31, 2026
PhilippeMaincon
left a comment
PhilippeMaincon
left a comment
Collaborator
There was a problem hiding this comment.
Great work! I approve the PR - but request small changes
- I am nit-picking here and there, you decide
- branch dev has changed since you started on this work: you MUST
- merge dev into your branch (that's right, in that direction)
- run_CI_test.jl
- merge your branch into dev. Remember to push dev
- delete your branche[s]
Call me for any questions(discussion)
Thank you, and sorry for the delay in reviewing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the possibility in DIrectXUA to add initialtrajectories (dependent on time) as a primer vector for each experiment instead of deepcopying the initialstate for each timestep.