Repository navigation
fix(keeper): set TimeBounds on keeper transactions so timed-out txs expire - #1351
Merged
abayomicornelius merged 1 commit intoOct 20, 2026
Merged
Conversation
|
@defimomof2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved
Keeper transactions have no time bounds (Preconditions::None), so a poll-timed-out transaction can still land minutes later #1236 — Keeper transactions have no time bounds (
Preconditions::None), so a poll-timed-out transaction can still land minutes laterChanges:
TX_MAX_TIME_SECS = 60constant totx_builder.rs— matches the poll budget (~6 attempts × up to 16 s backoff).max_time: u64parameter tobuild_invoke_tx;0meansPreconditions::None(used for simulation calls where sequence is irrelevant).set_prices,execute_handler) now passnow_unix + TX_MAX_TIME_SECS, so a timed-out transaction is guaranteedtx_too_latebefore the key is retried.0(no expiry needed).TimeBounds,TimePointtotx_builder.rsimports fromstellar_xdr.Preconditions::Nonewhenmax_time = 0; added new test for thePreconditions::Timepath.Closes #1236
closes #1247
To be completed