Add SHA-384 MAC digest support - #77
Open
jelinek-wgs wants to merge 1 commit into
Open
jelinek-wgs wants to merge 1 commit into
jelinek-wgs wants to merge 1 commit into
Conversation
The classic PKCS#12 MAC (RFC 7292) only supports SHA-1, SHA-256 and SHA-512; SHA-384 (OID 2.16.840.1.101.3.4.2.2) is rejected with "unknown digest algorithm". This affects PKCS#12 files exported with `openssl pkcs12 -export -macalg sha384`. - pbkdf.go: add sha384Sum helper. - mac.go: add oidSHA384, wire into doMac (RFC 7292 Appendix B.2: u=48, v=128 bytes). - pkcs12_test.go: add TestPKCS12_SHA384MAC using a real OpenSSL- generated fixture (verified via `openssl pkcs12 -info`).
jelinek-wgs
force-pushed
the
add-sha384-mac-support
branch
from
July 2, 2026 18:34
a7933bc to
99c0845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classic PKCS#12 MAC (RFC 7292) only supports SHA-1, SHA-256 and SHA-512; SHA-384 (OID 2.16.840.1.101.3.4.2.2) is rejected with "unknown digest algorithm". This affects PKCS#12 files exported with
openssl pkcs12 -export -macalg sha384.openssl pkcs12 -info).