fix(build): pin TypeScript to 5.9.x so the API bundle builds - #752
Open
RubenHalman wants to merge 1 commit into
Open
fix(build): pin TypeScript to 5.9.x so the API bundle builds#752RubenHalman wants to merge 1 commit into
RubenHalman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarn workspace @orgcheck/api buildfails on a clean install ofmain:orgcheck-apiandorgcheck-sfdx-plugindeclare"typescript": "^7.0.2", which resolves to TypeScript 7, the native rewrite. Its JS API no longer exposesScriptTargetandModuleKindthe way@rollup/plugin-typescript@12.3.0expects, so the plugin's module-kind validation readsundefinedat import time.ts-jest@29also caps atpeer typescript ">=4.3 <7".This pins both packages to the 5.9 line, the highest version both tools support.
Verified on macOS 26.5, Node 24.18, Yarn 4.18:
dist/orgcheck.jsanddist/orgcheck.d.tsare produced and the bundled test passesOne note that is out of scope here: on Yarn 4 the
packstep that follows the rollup build still fails, because Yarn 4 names the tarballpackage.tgzwhilepostpackmovesorgcheck-api-*.tgz. That is independent of the TypeScript version and does not affect the bundle.