Skip to content

fix(cli): correct input normalization regressions - #655

Merged
Seddryck merged 4 commits into
next-majorfrom
fix/input-normalization-regressions
Aug 26, 2026
Merged

fix(cli): correct input normalization regressions#655
Seddryck merged 4 commits into
next-majorfrom
fix/input-normalization-regressions

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • count parsed --batch identifiers instead of matching raw tokens
  • reject duplicate IDataReader column names before record construction
  • consume configured multi-row and repeated CSV headers without emitting them as data
  • reject UTF-16 and UTF-32 BOMs while preserving UTF-8 BOM support

Validation

  • Added regression tests before each fix and observed them fail, then pass unchanged after the implementation
  • dotnet build Expressif.sln --nologo --no-restore
  • dotnet test Expressif.sln --nologo --no-build --no-restore
  • dotnet format Expressif.sln analyzers --verify-no-changes --no-restore
  • pre-push StyleCop hook

Close #651
Close #652
Close #653
Close #654

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3803ac7c-cfb1-4ce3-8879-1cae0f4bdaff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.72%. Comparing base (2e0e6ab) to head (9229f17).
⚠️ Report is 1 commits behind head on next-major.

Files with missing lines Patch % Lines
...pressif.Cli/Infrastructure/SourceInfrastructure.cs 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           next-major     #655      +/-   ##
==============================================
+ Coverage       84.65%   84.72%   +0.06%     
==============================================
  Files             218      218              
  Lines            5970     6008      +38     
  Branches         1049     1060      +11     
==============================================
+ Hits             5054     5090      +36     
- Misses            600      602       +2     
  Partials          316      316              
Flag Coverage Δ
expressif-cli-net10.0 39.84% <97.77%> (+0.38%) ⬆️
expressif-net10.0 81.68% <ø> (ø)
expressif-net8.0 81.68% <ø> (ø)
expressif-net9.0 81.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant