Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(benchmark): compare supplied Expressif versions #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(benchmark): compare supplied Expressif versions #657
Changes from all commits
f444eed5fb4f522b9c30b3af09ec0a84190File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 34 in benchmark/Expressif.Benchmark/ExpressionAdapter.cs
Extract this nested ternary operation into an independent statement.
Check warning on line 42 in benchmark/Expressif.Benchmark/ExpressionAdapter.cs
Change this condition so that it does not always evaluate to 'True'. Some code paths are unreachable.
Check warning on line 43 in benchmark/Expressif.Benchmark/ExpressionAdapter.cs
The parameter name 'kind' is not declared in the argument list.
Check warning on line 94 in benchmark/Expressif.Benchmark/ExpressionAdapter.cs
Remove this null-forgiving operator; nullable warnings are disabled here.
Uh oh!
There was an error while loading. Please reload this page.