Skip to content

fix: insert implicit pipeline coercions during binding - #661

Merged
Seddryck merged 1 commit into
next-majorfrom
fix/implicit-pipeline-coercion
Aug 26, 2026
Merged

fix: insert implicit pipeline coercions during binding#661
Seddryck merged 1 commit into
next-majorfrom
fix/implicit-pipeline-coercion

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • insert explicit coercion function members between incompatible typed pipeline stages during binding
  • enable coercion insertion by default while allowing applyCoercion: false
  • preserve dynamic or ambiguous function-contract fallback behavior
  • include the variadic Array and Spread work from feat(array): add variadic array construction #660

Validation

  • full solution build
  • full solution tests on .NET 8, 9, and 10
  • analyzer verification
  • regression coverage for the trim, multiply, round, and euro prepend pipeline in coercing and non-coercing modes

Close #659

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3dd6cbc6-06ae-48ce-af07-335c36f6289f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.08197% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.40%. Comparing base (3f67f0c) to head (9ca6663).

Files with missing lines Patch % Lines
Expressif/Functions/FunctionFactory.cs 95.23% 0 Missing and 3 partials ⚠️
Expressif/Functions/Special/CoerceFunctions.cs 50.00% 0 Missing and 2 partials ⚠️
Expressif/Functions/ChainFunction.cs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           next-major     #661      +/-   ##
==============================================
+ Coverage       84.25%   84.40%   +0.15%     
==============================================
  Files             219      219              
  Lines            6143     6254     +111     
  Branches         1089     1111      +22     
==============================================
+ Hits             5176     5279     +103     
- Misses            641      645       +4     
- Partials          326      330       +4     
Flag Coverage Δ
expressif-cli-net10.0 40.77% <84.42%> (+1.03%) ⬆️
expressif-net10.0 81.45% <95.08%> (+0.41%) ⬆️
expressif-net8.0 81.45% <95.08%> (+0.41%) ⬆️
expressif-net9.0 81.45% <95.08%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Seddryck
Seddryck force-pushed the fix/implicit-pipeline-coercion branch from ddf5645 to 9ca6663 Compare August 26, 2026 10:47
@sonarqubecloud

Copy link
Copy Markdown

@Seddryck
Seddryck merged commit e4e21d2 into next-major Aug 26, 2026
18 checks passed
@Seddryck
Seddryck deleted the fix/implicit-pipeline-coercion branch August 26, 2026 12:01
@Seddryck Seddryck linked an issue Aug 26, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply implicit coercion while binding typed pipelines

1 participant