Skip to content

[Tests] Refactor replay tests to use real filesystem#7431

Open
gonzaloriestra wants to merge 1 commit intomainfrom
tester-refactor-replay-tests-14017228650899711317
Open

[Tests] Refactor replay tests to use real filesystem#7431
gonzaloriestra wants to merge 1 commit intomainfrom
tester-refactor-replay-tests-14017228650899711317

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented Apr 30, 2026

WHY are these changes introduced?

packages/app/src/cli/services/function/replay.test.ts mocked the filesystem (vi.mock('fs') and vi.mock('@shopify/cli-kit/node/fs')) and shared mutable state across tests via beforeAll. Filesystem mocks drift from the real implementation, and shared state makes tests order-dependent and harder to reason about. The CLI testing strategy prefers real files in temporary directories with isolated state per test.

WHAT is this pull request doing?

  • Removes the fs and @shopify/cli-kit/node/fs mocks.
  • Adds a runTest helper that uses inTemporaryDirectory to give every test its own isolated workspace, function extension, and logs directory.
  • Writes real function-run JSON files to disk instead of stubbing readers.
  • Normalizes assertions so they tolerate deterministic order and generated identifiers.
  • Replaces the beforeAll setup with the per-test helper, eliminating shared mutable state.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 30, 2026 00:21
@github-actions github-actions Bot added cla-needed no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. labels Apr 30, 2026
Refactored replay.test.ts to use inTemporaryDirectory and real
filesystem operations instead of mocks. Eliminated shared state
by replacing beforeAll with a setup helper.

Made-with: Cursor
@gonzaloriestra gonzaloriestra force-pushed the tester-refactor-replay-tests-14017228650899711317 branch from 25815d2 to 76bc6f1 Compare April 30, 2026 07:57
@gonzaloriestra gonzaloriestra changed the title 🧪 Tester: Refactor replay tests to use real filesystem [Tests] Refactor replay tests to use real filesystem Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant