Skip to content

[Refactor] Improve copyDirectoryContents efficiency and cleanup knip config#7447

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-copy-directory-contents-efficiency-1894134398803177433
Draft

[Refactor] Improve copyDirectoryContents efficiency and cleanup knip config#7447
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-copy-directory-contents-efficiency-1894134398803177433

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The current implementation of copyDirectoryContents was inefficiently performing manual string replacements on absolute paths to calculate relative destination paths. Additionally, the knip configuration contained stale ignoreDependencies entries.

WHAT is this pull request doing?

  1. Refactored copyDirectoryContents: Used the cwd option in glob to directly obtain relative paths, eliminating the need for brittle manual path stripping. Simplified the copy loop using Promise.all with map.
  2. Cleaned up knip configuration: Removed unused @graphql-typed-document-node/core entries from ignoreDependencies in package.json for both packages/app and packages/cli-kit.
  3. Documented Learnings: Added key performance and refactoring insights to .jules/refactor.md and .jules/bolt.md.

How to test your changes?

Run the unit tests for cli-kit's filesystem utilities:

pnpm --filter @shopify/cli-kit vitest run src/public/node/fs.test.ts

Verify that knip no longer reports configuration hints:

pnpm knip

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct [bump type] and added a changeset with pnpm changeset add

PR created automatically by Jules for task 1894134398803177433 started by @gonzaloriestra

…config

- Updated `copyDirectoryContents` in `packages/cli-kit/src/public/node/fs.ts` to use `cwd` in `glob` for more efficient path mapping and cleaner code.
- Removed unused `ignoreDependencies` entries from `package.json` for `packages/app` and `packages/cli-kit` as flagged by `knip`.
- Simplified the parallel copy loop in `copyDirectoryContents`.
- Recorded learnings in `.jules/refactor.md` and `.jules/bolt.md`.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant