[Refactor] Improve copyDirectoryContents efficiency and cleanup knip config#7447
[Refactor] Improve copyDirectoryContents efficiency and cleanup knip config#7447gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
…config - Updated `copyDirectoryContents` in `packages/cli-kit/src/public/node/fs.ts` to use `cwd` in `glob` for more efficient path mapping and cleaner code. - Removed unused `ignoreDependencies` entries from `package.json` for `packages/app` and `packages/cli-kit` as flagged by `knip`. - Simplified the parallel copy loop in `copyDirectoryContents`. - Recorded learnings in `.jules/refactor.md` and `.jules/bolt.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The current implementation of
copyDirectoryContentswas inefficiently performing manual string replacements on absolute paths to calculate relative destination paths. Additionally, theknipconfiguration contained staleignoreDependenciesentries.WHAT is this pull request doing?
copyDirectoryContents: Used thecwdoption inglobto directly obtain relative paths, eliminating the need for brittle manual path stripping. Simplified the copy loop usingPromise.allwithmap.knipconfiguration: Removed unused@graphql-typed-document-node/coreentries fromignoreDependenciesinpackage.jsonfor bothpackages/appandpackages/cli-kit..jules/refactor.mdand.jules/bolt.md.How to test your changes?
Run the unit tests for
cli-kit's filesystem utilities:Verify that
knipno longer reports configuration hints:Checklist
pnpm changeset addPR created automatically by Jules for task 1894134398803177433 started by @gonzaloriestra