[Performance] Optimize copyDirectoryContents using glob cwd#7450
[Performance] Optimize copyDirectoryContents using glob cwd#7450gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
The `copyDirectoryContents` function used an absolute path with `glob`, followed by manual string replacement to calculate relative paths for the destination. This is less efficient and more error-prone than using the built-in `cwd` option in `glob`. This change: - Updates `copyDirectoryContents` to use the `cwd` option in the `glob` call. - Simplifies the relative path calculation by removing manual string stripping. - Reduces memory overhead by working with relative paths during the globbing process.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
copyDirectoryContentsfunction used an absolute path withglob, followed by manual string replacement to calculate relative paths for the destination. This is less efficient and more error-prone than using the built-incwdoption inglob.WHAT is this pull request doing?
copyDirectoryContentsto use thecwdoption in theglobcall.How to test your changes?
Run the unit tests for
cli-kit:pnpm --filter @shopify/cli-kit vitest run src/public/node/fs.test.tsVerification command:
pnpm nx lint cli-kit && pnpm nx type-check cli-kitChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 15242362493404967590 started by @gonzaloriestra