Skip to content

[Performance] Optimize copyDirectoryContents using glob cwd#7450

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
bolt-optimize-copy-directory-contents-15242362493404967590
Draft

[Performance] Optimize copyDirectoryContents using glob cwd#7450
gonzaloriestra wants to merge 1 commit intomainfrom
bolt-optimize-copy-directory-contents-15242362493404967590

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The copyDirectoryContents function used an absolute path with glob, followed by manual string replacement to calculate relative paths for the destination. This is less efficient and more error-prone than using the built-in cwd option in glob.

WHAT is this pull request doing?

  • Updates copyDirectoryContents to use the cwd option in the glob call.
  • Simplifies the relative path calculation by removing manual string stripping.
  • Reduces memory overhead by working with relative paths during the globbing process.

How to test your changes?

Run the unit tests for cli-kit:
pnpm --filter @shopify/cli-kit vitest run src/public/node/fs.test.ts

Verification command:
pnpm nx lint cli-kit && pnpm nx type-check cli-kit

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 15242362493404967590 started by @gonzaloriestra

The `copyDirectoryContents` function used an absolute path with `glob`, followed by manual string replacement to calculate relative paths for the destination. This is less efficient and more error-prone than using the built-in `cwd` option in `glob`.

This change:
- Updates `copyDirectoryContents` to use the `cwd` option in the `glob` call.
- Simplifies the relative path calculation by removing manual string stripping.
- Reduces memory overhead by working with relative paths during the globbing process.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant