[Tests] Make 'refreshes extension url' test deterministic#7461
[Tests] Make 'refreshes extension url' test deterministic#7461gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
Unskip the 'refreshes extension url' test in `extensionServerReducer.test.ts` and refactor it to use Vitest's fake timers. This removes the dependency on real time and `setTimeout`, making the test faster and deterministic. Exact timestamp assertions are also added for better verification.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The test
refreshes extension urlinpackages/ui-extensions-server-kit/src/state/reducers/extensionServerReducer.test.tswas skipped and relied on real-time passage (setTimeout) to verify timestamp changes. This is non-deterministic and can lead to flakiness.WHAT is this pull request doing?
refreshes extension urltest.vi.useFakeTimers()andvi.setSystemTime().setTimeoutblock, making the test synchronous and faster.How to test your changes?
Run the unit tests for the affected package:
Checklist
PR created automatically by Jules for task 8839888816816504392 started by @gonzaloriestra