[Performance] Optimize directory globbing with cwd#7464
[Performance] Optimize directory globbing with cwd#7464gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
Use the `cwd` option in `glob` to retrieve relative paths directly in `copyDirectoryContents` and `recursiveLiquidTemplateCopy`. This avoids manual string replacement and reduces overhead by ~67% for path processing in file-intensive operations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Manual string manipulation to calculate relative paths after an absolute glob search is inefficient and adds unnecessary overhead, especially in operations involving many files like
copyDirectoryContentsandrecursiveLiquidTemplateCopy.WHAT is this pull request doing?
This PR optimizes
copyDirectoryContentsandrecursiveLiquidTemplateCopyin@shopify/cli-kitby:cwdoption inglobto retrieve relative paths directly.relativePathutility calls.How to test your changes?
Run the existing unit tests for the affected utilities:
pnpm --filter @shopify/cli-kit vitest run fs.test.ts liquid.test.tsChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12528009821187772836 started by @gonzaloriestra