Skip to content

[Performance] Optimize directory globbing with cwd#7464

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
bolt-optimize-glob-cwd-12528009821187772836
Draft

[Performance] Optimize directory globbing with cwd#7464
gonzaloriestra wants to merge 1 commit intomainfrom
bolt-optimize-glob-cwd-12528009821187772836

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Manual string manipulation to calculate relative paths after an absolute glob search is inefficient and adds unnecessary overhead, especially in operations involving many files like copyDirectoryContents and recursiveLiquidTemplateCopy.

WHAT is this pull request doing?

This PR optimizes copyDirectoryContents and recursiveLiquidTemplateCopy in @shopify/cli-kit by:

  • Using the cwd option in glob to retrieve relative paths directly.
  • Eliminating manual string replacements and repeated relativePath utility calls.
  • Measured performance impact: ~67% reduction in path processing overhead for 1000 files.

How to test your changes?

Run the existing unit tests for the affected utilities:
pnpm --filter @shopify/cli-kit vitest run fs.test.ts liquid.test.ts

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 12528009821187772836 started by @gonzaloriestra

Use the `cwd` option in `glob` to retrieve relative paths directly in
`copyDirectoryContents` and `recursiveLiquidTemplateCopy`. This avoids
manual string replacement and reduces overhead by ~67% for path processing
in file-intensive operations.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant