Fix Docker build by using correct imgsort binary name#88
Merged
Conversation
The Dockerfile was copied from the github-backup project and still referenced the github-backup binary, which doesn't exist in the build context. CI builds and uploads an artifact named imgsort, so the Docker build failed when ADDing ./github-backup. Update the Dockerfile to package the imgsort binary, and fix the leftover image source/description metadata (both in the Dockerfile labels and the workflow's index annotation) to describe imgsort. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FfLsHiJZK8LDnUBtJy7WX6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build was failing because the
Dockerfilestill referenced thegithub-backupbinary — leftover from when it was copied out of the github-backup project.The
docker-buildjob in.github/workflows/rust.ymlbuilds and uploads an artifact namedimgsort, downloads it into the build context, and marks./imgsortexecutable. But the Dockerfile then tried toADD ./github-backup, a file that doesn't exist in the context, so the build failed.Changes
Dockerfile: package./imgsortinstead of./github-backupand use it as the entrypoint.Dockerfile: fix the leftoverorg.opencontainers.image.sourceandorg.opencontainers.image.descriptionlabels (and the header comment) to describe imgsort..github/workflows/rust.yml: fix the matchingannotation-index.org.opencontainers.image.descriptionthat also carried the old github-backup description.🤖 Generated with Claude Code
https://claude.ai/code/session_01FfLsHiJZK8LDnUBtJy7WX6
Generated by Claude Code