Release v2.5.1#29
Merged
Merged
Conversation
…c/use-cache options + 30d/1y tiers
- Separate the data-fetch cache (POST caches WITH next options) from route
rendering (POST-read route still emits private/no-store) — the WEB-1069 gotcha
- Document the three rendering-layer fixes: CDN edge override (shipped),
force-static (interim, needs null-safety + throw-on-5xx), use cache (strategic)
- Raise revalidate tiers to 30d (CCDS/WP) and image minimumCacheTTL to 1y
- Correct the prior claim that next:{revalidate,tags} alone makes a POST page cacheable
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Document expireTime semantics: s-maxage=<revalidate>, SWR=<expireTime-revalidate>; must be >= largest revalidate. Set 5184000 (60d) for a uniform 30d/30d header. - Update proxy override value to public, s-maxage=2592000, stale-while-revalidate=2592000 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed
caching.instructions.md/nextjs-cachingskill — corrected the POST-read caching claim (WEB-1069). The previous guidance impliednext: { revalidate, tags }alone was sufficient to make a POST-read page (e.g. CCDSgeo-search, which powers city/community pages) CDN-cacheable. Production testing showed the data fetch caches with those options, but the route still renders dynamically (cache-control: private, no-store) — the two are independent facts. Both documents now separate the data-fetch cache fact from the route-rendering fact and document the three fixes: CDN edge override (proxy.ts, shipped default),dynamic = "force-static"(interim, requires null-safety + throw-on-5xx), andcacheComponents+use cache(strategic).minimumCacheTTLto 1 year — CCDS/WP data changes rarely and is refreshed on-demand via webhooks + tags, so the previous 24h/30d defaults were unnecessarily short.expireTime/ CDN stale-window rule — Next emitss-maxage=<revalidate>, stale-while-revalidate=<expireTime - revalidate>for ISR pages, soexpireTimemust be ≥ the largest pagerevalidateor the stale window is invalid. Added the correct value (5184000, 60d) and the matching proxy override value (s-maxage=2592000, stale-while-revalidate=2592000).Release
package.json,package-lock.json,src/index.jsVERSION).Post-merge
publish.ymltriggers onrelease: [created], so a bare tag push will not publish to npm — a GitHub Release must be created after this merges:git checkout main && git pull git tag v2.5.1 git push origin v2.5.1 gh release create v2.5.1 --generate-notesTest plan
npm test— 44/44 passingpackage.json/package-lock.json/src/index.jsVERSIONin sync at 2.5.1🤖 Generated with Claude Code