Skip to content

fix: 🐛 null-check crash in ShowcaseController._initRootWidget when the Showcase is unmounted in the same frame it mounts (#659) #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apurva010 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 🐛 null-check crash in ShowcaseController._initRootWidget when the Showcase is unmounted in the same frame it mounts (#659) #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.1.1 [#unreleased]

- Fixed [#659](https://github.com/SimformSolutionsPvtLtd/showcaseview/issues/659) - Fix null-check crash in `ShowcaseController._initRootWidget` when the `Showcase` is unmounted in the same frame it mounts. Fixed by @[apurva-simform](https://github.com/apurva-simform)

## 5.1.0

- Fixed [#650](https://github.com/SimformSolutionsPvtLtd/showcaseview/issues/650) - Fix null-check crash in ShowcaseService.getController during didUpdateWidget. Fixed by @[vatsaltanna-simformsolutions](https://github.com/vatsaltanna-simformsolutions)
Expand Down
3 changes: 3 additions & 0 deletions lib/src/showcase/showcase_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ class ShowcaseController {
///
/// Must be called after the widget is mounted to ensure proper measurements.
void _initRootWidget() {
// register()'s post-frame callback can fire after the Showcase was
// unmounted in the same frame, and State.context throws on a dead State.
if (!_mounted) return;
final rootWidget = _context.findRootAncestorStateOfType<State<Overlay>>();
rootRenderObject = rootWidget?.context.findRenderObject() as RenderBox?;
rootWidgetSize = rootWidget == null
Expand Down
Loading