Skip to content

Create and edit modal polish (#73) - #89

Merged
SlyDave merged 1 commit into
mainfrom
frontend/issue-73
Jul 27, 2026
Merged

Create and edit modal polish (#73)#89
SlyDave merged 1 commit into
mainfrom
frontend/issue-73

Conversation

@SlyDave

@SlyDave SlyDave commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rename the board add control to Create task to match the modal title.
  • Description spans full modal width; colour picker always visible with None default (no checkbox); wide colour preview.
  • Remove Optional/Required helper text; disable Create task when description is empty; enforce title/description maxlength via domain constants.

Closes #73

Acceptance criteria

  • Create task label on primary add affordance — BOARD_ADD_TASK_LABEL.
  • Description full width — w-full on description field and form.
  • Colour picker always visible, default none, no checkbox, wide preview — preset select + full-width colour input.
  • No Optional/Required helpers — hints removed; description still marked required with asterisk.
  • Create task disabled without description / enabled with non-empty — taskFormCanSubmit + :disabled.
  • Title max 50 / description max 5000 — TITLE_MAX_LENGTH / DESCRIPTION_MAX_LENGTH on inputs.

Test plan

  • Open create modal: Create task disabled until description entered
  • Confirm no Optional/Required helper text; description shows required asterisk
  • Colour preset defaults to None; picker visible and wide; custom colour submits a hex
  • Title/description cannot exceed 50/5000 characters

@SlyDave SlyDave left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA verdict: approved

Verified against #73 acceptance criteria on frontend/issue-73 (local Nuxt at :3073) plus unit tests (taskFormCopy.test.ts, boardCopy.test.ts).

Criterion Result Evidence
Primary add label Create task Pass [data-testid=board-add-task] text
Description full modal width Pass Description width matches form (441px)
Colour picker always visible; default None; no checkbox; wide preview Pass Colour input visible (~266px); preset None; no checkbox
No Optional/Required helper text; required asterisk/attr on description Pass Form copy clean; description has required
Create task disabled when description empty Pass Submit disabled until description filled
Create task enabled with non-empty description Pass Enabled after fill
Title max 50 / description max 5000 Pass maxlength 50 / 5000

CI green on the PR.

@SlyDave SlyDave added the qa:approved QA verified this against the acceptance criteria and it passed label Jul 27, 2026
@SlyDave
SlyDave merged commit f9b6cc7 into main Jul 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa:approved QA verified this against the acceptance criteria and it passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create and edit modal polish

1 participant