Readable text on custom card backgrounds (#77) - #90
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
SlyDave
commented
Jul 27, 2026
SlyDave
left a comment
Owner
Author
There was a problem hiding this comment.
QA verdict: approved
Verified against #77 acceptance criteria on frontend/issue-77 (local Nuxt at :3077) plus unit tests (taskCardContrast.test.ts 3/3). Seeded todo.tasks.v1 with light (#ffffff), dark (#000000), and none backgrounds.
| Criterion | Result | Evidence |
|---|---|---|
| Custom bg → luminance contrast on title/body | Pass | White card → #111827 / rgb(17,24,39); black card → #f9fafb / rgb(249,250,251) |
| Background none → theme colours | Pass | No inline colour; theme oklch(...) classes remain |
| Custom bg contrast ignores theme alone | Pass | Under dark theme, white card still uses dark contrast text |
CI was in progress at review start; unit + browser checks cover the ACs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contrastTextColourto task card title and description when a custom background is set.Closes #77
Acceptance criteria
taskCardContrastText+ inline colour on title and description.null;text-highlighted/text-mutedremain.Test plan