Handle double clicking a checkbox#720
Closed
SharonStrats wants to merge 3 commits intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses SolidOS/solid-ui issue #124 by preventing double-clicks on an editable checkbox from triggering overlapping kb.updater.update() operations, which can lead to inconsistent UI state and update errors.
Changes:
- Add an
isUpdatingguard to ignore additional clicks while an update is in progress. - Disable the checkbox button during the update and re-enable it in the update callback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
timea-solid
approved these changes
Apr 2, 2026
Contributor
Author
|
moved to post-milestone3m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #124.
You can test this on a Tracker in the settings there is a place to check public and private indexes. This triggered teh error for me.