perf: batch join tab-list sync into a single CPlayerInfoUpdate - #550
Draft
carabistouflette wants to merge 1 commit into
Draft
carabistouflette wants to merge 1 commit into
carabistouflette wants to merge 1 commit into
Conversation
github-actions
Bot
added
Enhancement
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
sync_tab_list previously queued O(N) create_player_initializing packets plus an optional update_chat_session packet per online player to the joiner. Mirroring vanilla PlayerList.placeNewPlayer, the joiner now receives one PLAYER_INFO_INIT_ACTIONS update whose entries carry every online player with their chat session data attached directly. Adds CPlayerInfoUpdate::create_player_initializing_entry so single-entry and batched construction share one code path, plus a regression test asserting the joiner receives exactly one packet.
carabistouflette
force-pushed
the
pr9-join-tablist-batching
branch
from
August 29, 2026 01:07
6fdd603 to
30099d7
Compare
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Batches tab-list initialization for joining players.
sync_tab_listpreviously queued O(N)create_player_initializingpackets plus an optionalupdate_chat_sessionpacket per online player to the joiner. Mirroring vanillaPlayerList.placeNewPlayer, the joiner now receives a singleCPlayerInfoUpdatewhose entries carry every online player with their chat session data attached directly via theInitializeChataction. The broadcast announcing the joiner to existing players is unchanged.CPlayerInfoUpdate::create_player_initializing_entryis extracted so single-entry and batched construction share one code path.How this was tested
sync_tab_list_sends_single_batched_update_to_joiner: with two existing players, the joiner receives exactly one tab-list packet and each existing player receives exactly one join announcement.cargo test -p steel-core --lib(2422 tests) pass;cargo clippy -r --all-targetsclean.Screenshots / logs
N/A.
Checklist
Additional notes