perf: demote audited movement and menu packets to narrower execution lanes - #553
Draft
carabistouflette wants to merge 1 commit into
Draft
perf: demote audited movement and menu packets to narrower execution lanes#553carabistouflette wants to merge 1 commit into
carabistouflette wants to merge 1 commit into
Conversation
…lanes Concurrency audit of the scheduled packet lanes: - MovePlayer and MoveVehicle handlers mutate only per-player movement and teleport state behind SyncMutex and route through chunk-map ticket APIs with fine-grained internal locks; they are demoted from Serialized to PlayerLocal, taking the hottest packet path off the global lane - ContainerButtonClick and ContainerSlotStateChanged join ContainerClick on the Serialized lane: menu transactions serialize on the menu lock, so the previous Exclusive barrier was unnecessarily wide - Attack, Interact, CustomPayload, and ReleaseUseItem remain Exclusive (combat spans independently locked source and target state; custom payloads have no constrained resource contract) Classification tests updated accordingly, with a new menu-lane test and an Interact barrier assertion.
carabistouflette
force-pushed
the
pr6-packet-lane-audit
branch
from
August 29, 2026 01:05
419800c to
69b30c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Concurrency audit of the scheduled packet lanes (see per-handler notes in
ScheduledPlayPacketKind::execution):Serialized). The handlers mutate only per-player movement and teleport state behindSyncMutexand route through chunk-map ticket APIs with fine-grained internal locks; collision lookups are read-only. This takes the hottest packet path off the global serialized lane.Exclusive). Menu transactions serialize on the menu lock exactly likeContainerClick, so the full global barrier was unnecessarily wide.The
ScheduledPacketExecutiondoc comment documents the per-lane safety invariants.How this was tested
packet_execution_classification_separates_local_and_serialized_worknow asserts MovePlayer = PlayerLocal; newmenu_transactions_share_the_serialized_laneasserts Click/ButtonClick/SlotStateChanged = Serialized;cross_player_handlers_remain_global_barriers(renamed) asserts Attack/Interact/ReleaseUseItem = Exclusive.cargo test -p steel-core --lib(2423 tests) pass;cargo clippy -r --all-targetsclean.Screenshots / logs
N/A.
Checklist
Additional notes
Serializedwhile keeping the menu demotions.