Merge tag 4.2.0 into 4.x (retry)#1716
Merged
Merged
Conversation
> [!TIP] > Close and reopen this pull request to run status checks.
…http would be registered as non-secure (but with the https port number) in Consul (#1596)
…1604) * Expose secure/non-secure uris on service instance * Optimize returned instances from Eureka
* Optimize NuGet package restore Don't query for all packages in all feeds * Trigger component builds on nuget.config change
* Reduce the level of recurring logging to reduce noise in apps * Remove redundant ? * Log at Info level only the first time
…ymous delegates, and is thus not safe to be called multiple times. (#1609) With a pre-check in place, several Try* methods behind it can be replaced for efficiency, but only if: - The implementation is an internal type and does not implement a public interface - The implementation type is not shared between Steeltoe components
…ogs with CLR dump logs (#1610)
* Update dependent package versions to capture dumps * Fixed: assembly load exception during gcdump in consuming app Steeltoe employs a trick to download the gcdump assembly without referencing it (because adding a PackageReference to a tool package is not possible). The same needs to be done in consuming apps.
* Update to latest Sonar version * Fix IDE0340: Use unbound generic type * Fix IDE0031: Null check can be simplified, add suppression to workaround Sonar bug * Update to new R# major version * Install .NET 10 in workflows, update setup-dotnet version * Resharper: use field keyword * Add net10.0 to target frameworks in test projects * Run tests against .NET 10 in workflows * Adapt for breaking change in JsonStreamConfigurationProvider * Suppress new warning in tests: CA1873 Avoid potentially expensive logging * Suppress obsolete warnings for WebHostBuilder/WebHost * Adapt test for new ForwardedHeadersOptions.KnownIPNetworks property * Adapt test for cleaned logging * Adapt for changed SQL Server connection string (EF Core 10 adds the app name) * Add workaround for missing stable/unstable packages for EF Core 10 * Remove the need for some suppressions * Sync up with ConfigurationSchemaGenerator changes in Aspire v13 * Remove redundant Sonar suppression * Package updates * Multi-target Steeltoe against net8.0/net10.0 * Address new issues after multi-targeting * Increase cibuild timeouts
* Fix gcdump publish and transitive references * Remove comment
* Dispose CapturingLoggerProvider in tests * Remove redundant typeof(...).FullName in string interpolations * Log warning on configureMiddleware false with custom middleware * Add support for UsePathBase in actuators * Apply suggestions from code review Co-authored-by: Tim Hess <tim.hess@broadcom.com> --------- Co-authored-by: Tim Hess <tim.hess@broadcom.com>
* Bump GHA versions * Update R#, tweak code cleanup - Address breaking change: version is no longer printed - Build upfront - Do not check for updates - Skip NuGet vulnerability checks - Skip roslyn analyzers * Fix test isolation for memory dumps * Fixed: Redis security tests did not run on net10.0 * Reuse shared settings for ConfigurationSchemaGeneratorTests * Replace test categories for OS filter with xUnit attributes * Do not skip Redis test on macOS * Increase timeout for flaky test on Windows * Review feedback: remove extended timeout * Review feedback: rename skip attributes * Review feedback: remove skipFilter * Review feedback: rename skip attributes in comments
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
* Fix broken tests in WSL2 on Ubuntu * Run tests for all frameworks in single command, explicitly use VSTest mode * Add diagnostics to investigate intermittent hostname lookup failures on macOS * Add workaround to enable hang/crashdumps on macOS * Reduce hang timeout (otherwise component job is killed before dump is uploaded) * TEST: Add new tests to verify coverage diff * Revert "TEST: Add new tests to verify coverage diff" This reverts commit 28263c5. * TEST: Add test that crashes with StackOverflowException * Revert "TEST: Add test that crashes with StackOverflowException" This reverts commit 4f84d3c. * TEST: Add test that never completes * Revert "TEST: Add test that never completes" This reverts commit 251ca8d. * Fixed: unable to discover tests in WSL Based on xunit/xunit#3457 (comment)
…1636) * Create a service scope for each ASP.NET health check, correct AddHealthContributor documentation * Update src/Management/test/Endpoint.Test/Actuators/Health/HealthAggregationTest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Clear non-indented HTML tags (used to be: html,body,thead,tbody,tfoot), hide hint to add return statement before local function * Reformat RazorPagesTestWebApp
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Tim Hess <tim.hess@broadcom.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Enable skipping AspNet health checks at actuator endpoint * Rename tag to ExcludeFromHealthActuator
* Fix CA1873: Potentially expensive logging * Refactor UriExtensions.ToMaskedString into MaskedUri struct with implicit conversion * Mask request URLs in HTTP exchanges actuator
…#1705) Snapshot from sample logs before the fix (press Ctrl+C on running FortuneTellerWeb): ```text dbug: Steeltoe.Discovery.Eureka.EurekaClient[868536339] HTTP DELETE request to 'http://localhost:8761/eureka/apps/STEELTOE.SAMPLES.FORTUNETELLERWEB/JVBD4M3%3ASteeltoe.Samples.FortuneTellerWeb%3A7233' returned status 404 in attempt 1. info: Steeltoe.Discovery.Eureka.EurekaClient[601900377] HTTP DELETE request to 'http://localhost:8761/eureka/apps/STEELTOE.SAMPLES.FORTUNETELLERWEB/JVBD4M3%3ASteeltoe.Samples.FortuneTellerWeb%3A7233' failed with status 404: '{"timestamp":"2026-05-28T11:15:52.686+00:00","status":404,"error":"Not Found","path":"/eureka/apps/STEELTOE.SAMPLES.FORTUNETELLERWEB/JVBD4M3%3ASteeltoe.Samples.FortuneTellerWeb%3A7233"}'. warn: Steeltoe.Discovery.Eureka.EurekaDiscoveryClient[1003466929] Deregister failed during shutdown. Steeltoe.Discovery.Eureka.Transport.EurekaTransportException: Failed to execute request on all known Eureka servers. ```
* Use HttpContext.Connection.LocalPort when evaluating management port * Management port must be less than 65536
- Add .*connectionstring.* to default keys to sanitize - Env actuator: sanitize connection strings and embedded credentials - Mask values containing Password= or Pwd= (case-insensitive) - Redact user:password@ sequences in URI-like values --------- Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- log when a redirect happens to avoid silent failure - add tests to verify auto-redirects are not followed --------- Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
* Create temp file with user-only access * Delete temporary cert files
- add integration test with Config Server - move non-hex salt theory data to AesTextDecryptorTest - add docker-compose for integration tests to repo root
--------- Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
Refactor cache invalidation for JWT keys and tests --------- Co-authored-by: Tim Hess <tim.hess@broadcom.com>
bart-vmware
force-pushed
the
merge-tag-420-into-4x
branch
from
27a4c12 to
f220ff0
Compare
TimHess
approved these changes
May 29, 2026
Contributor
Summary - All Code Coverage (ubuntu-latest)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same contents as #1712.