Init vehicle no tick (Client)#321
Open
Vitroze wants to merge 8 commits into
Open
Conversation
Owner
I'm pretty sure this was done during the beta, but was undone because the entity can be invalid on the client-side when the server sends it |
Contributor
Author
|
If you have a test case where the entity becomes invalid, I’d be interested to see it. The only scenario I can envision, though I’d be surprised if it actually caused an issue, is with instanced systems where you exit with a vehicle (like a garage system): creating the vehicle outside the player's PVS and then placing it inside. I’m skeptical, but it’s worth testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive optimization of the initialization system for when the player enters and exits the vehicle; this now operates via a network-based system.
I also decided to transmit the vehicle over the network to ensure its arrival, rather than relying on
GetVehiclefollowed byGetParent().I preferred keeping it in
eventsand making the functions global, since it involves a lot of hooks. If you want to make it local, I would move it tonetwork.