TangibleFieldsRenderer: Sections and Tabs - Switch to uncontrolled fields#39
Open
nicolas-jaussaud wants to merge 2 commits into
Open
TangibleFieldsRenderer: Sections and Tabs - Switch to uncontrolled fields#39nicolas-jaussaud wants to merge 2 commits into
nicolas-jaussaud wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @zinigor!
The way
accordionsandtabsworked in fields was not really compatible with the way we use them in the object moduleThey were both expecting a value, which takes the form of a JSON object that holds the value of each sub-field
As we were not passing this initial value, all fields were blank regardless of what was previously saved
I updated the fields module and added the possibility to have an "uncontrolled" mode for both the
accordionandtabfields, with that mode they should not expect a value and sub-fields will be populatedIt's not directly related, but I took the opportunity to remove the permission and store callbacks, as we don't rely on fields for saving data we can safely remove them
I also simplified the enqueue logic, as we can rely on fields to enqueue its assets when something is being rendered