respect argument separations when collecting separate values - #194
Merged
Conversation
Owner
|
Good catch. Nargs is perpetually a weird corner case. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate values collected even when they are disallowed
Dropping the
elsein e319b42 left the value-collection loop inParseArgsValuesrunning unconditionally, soSetArgumentSeparationsno longer reaches it: with separate values off,--jobs 3on anImplicitValueFlagtakes3instead of leaving it positional, and--nums=1 2fills aNargs{2, 3}flag. The awkward one is with joined short values off, where-nf 5now takes5as n's value, soParseShortbreaks out of the chunk andfis silently dropped with nothing reported. Gated the loop on separate values being allowed and on the joined value having actually been taken rather than discarded; the added test covers all three plus the joined-then-separate nargs case from e319b42, and fails on master.