fix: resume TimeManager when GameScene exit#824
Merged
liquidhelium merged 2 commits intoJul 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #822 by ensuring TimeManager is resumed when GameScene exits via paths other than should_exit, preventing UI/state issues caused by leaving the timer paused.
Changes:
- Resume
TimeManagerwhenGameScenereturns a non-NoneNextSceneviaself.next_scene. - Reset
TimeManagerspeed andadjust_timeon these exits (consistent with other exit paths).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1309
to
+1311
| if !matches!(next_scene, NextScene::None) { | ||
| tm.resume(); | ||
| } |
liquidhelium
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
相关Issue
#822
修复方式
当GameScene通过除should_exit外方式退出时恢复TimeManager