Add support for Granite 4.2 and fix cursor bugs - #33
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c9a61ae66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| low_effort = ( | ||
| resolved_kwargs.get("low_effort", False) is True | ||
| or resolved_kwargs.get("reasoning_effort") == "low" | ||
| ) |
There was a problem hiding this comment.
When a caller supplies chat_template_kwargs={"reasoning_effort": "low"}, this branch classifies the row as low_effort and enables thinking, but leaves only reasoning_effort in the arguments forwarded to the template. The documented live Granite template setting is low_effort=True (docs/training.md lines 156–162), so the rendered row can omit the low-effort prompt protocol while granite42_modes reports that it was applied. Either remove this alias or translate it to low_effort=True before rendering.
Useful? React with 👍 / 👎.
CompactAIOfficial
added
bug
CompactAIOfficial
changed the title
2 participants
Also attached are some cursor bug fixes