Skip to content

fix(job): 使用简洁失败文案 - #225

Merged
ThaddeusJiang merged 2 commits into
mainfrom
fix/job-error-message
Jul 1, 2026
Merged

ThaddeusJiang merged 2 commits into
mainfrom
fix/job-error-message

Conversation

@ThaddeusJiang

@ThaddeusJiang ThaddeusJiang commented Jun 16, 2026 •

Copy link
Copy Markdown
Owner

变更内容

  • failed job 的列表、详情页和通知不再展示 jobs.error 原始内容。
  • 失败文案改为基于 job kind/status 的简洁提示,告诉用户发生了什么以及如何应对。
  • 增加回归测试,确保 Ash/ReqLLM/provider 内部错误不会泄漏到 UI。
  • 补充 job 内部错误泄漏到 UI 的 postmortem。

根因

jobs.error 会保存 worker 失败时的诊断信息,但 UI 直接渲染了该字段,导致内部异常和 provider response 可能展示给用户。

验证

  • MIX_ENV=test mise exec -- mix test test/vmemo_web/live/jobs_live_test.exs test/vmemo_web/job_notifications_test.exs
  • 结果:15 tests, 0 failures
  • 本地 prod smoke:MIX_ENV=prod 启动 Phoenix 后,用 Browser 打开 failed caption job detail,确认 UI 展示 Caption generation failed. Please retry later. 且不展示内部异常。

本地 prod 验证截图

failed job detail shows concise user-facing error message

冲突处理

  • 已合并 main,保留主线 /media/images/:id/thumb 缩略图路径断言,并保留失败 job 的用户可读文案测试。

@ThaddeusJiang
ThaddeusJiang marked this pull request as ready for review July 1, 2026 14:14
@ThaddeusJiang
ThaddeusJiang merged commit bec0777 into main Jul 1, 2026
3 checks passed
@ThaddeusJiang
ThaddeusJiang deleted the fix/job-error-message branch July 1, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant