fix: code quality improvements in searches and sorts#14565
Open
JiayangLai wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
fix: code quality improvements in searches and sorts#14565JiayangLai wants to merge 1 commit intoTheAlgorithms:masterfrom
JiayangLai wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
- binary_search.py: fix return type check in exponential_search (is None -> == -1) - linear_search.py: use ValueError instead of generic Exception - merge_sort.py: avoid O(n) pop(0) operations by using index-based merging Co-Authored-By: Claude Opus 4.6 <[email protected]>
algorithms-keeper
bot
added
enhancement
mindaugl
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exponential_search- was checkingis Nonebut function returns-1when not foundValueErrorinstead of genericExceptionfor proper exception handlingpop(0)operations by using index-based merging for better performanceChanges
searches/binary_search.py: Fixedexponential_searchreturn value checksearches/linear_search.py: ChangedExceptiontoValueErrorsorts/merge_sort.py: Replacedpop(0)with index tracking to avoid O(n) shift operationsTest plan
🤖 Generated with Claude Code