Skip to content

Built-in {UpstreamScheme} placeholder - #2201

Open
rocleegithub wants to merge 2 commits into
ThreeMammals:developfrom
rocleegithub:merge-conflicts
Open

rocleegithub wants to merge 2 commits into
ThreeMammals:developfrom
rocleegithub:merge-conflicts

Conversation

@rocleegithub

@rocleegithub rocleegithub commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

New Feature #2193 #2195

Discussion thread

Support like this Placeholders for X-Forwarded-Proto #2195

"X-Forwarded-Proto": "{UpstreamScheme}"

@raman-m raman-m added the conflicts Feature branch has merge conflicts label Nov 26, 2024
@raman-m

raman-m commented Nov 26, 2024

Copy link
Copy Markdown
Member

@rocleegithub Please, resolve merge conflicts!

@raman-m raman-m changed the title add Placeholders item of {UpstreamScheme} Built-in {UpstreamScheme} placeholder Nov 26, 2024
@raman-m
raman-m force-pushed the develop branch 14 times, most recently from c216cdf to b458f0f Compare April 7, 2025 16:13
@raman-m
raman-m force-pushed the develop branch 13 times, most recently from 4ef4275 to 3e92ddd Compare April 18, 2025 17:07
@raman-m
raman-m force-pushed the develop branch 5 times, most recently from 908d84f to 0678e7a Compare April 19, 2025 15:13
@raman-m raman-m added the Autumn'26 Autumn 2026 release label May 27, 2025
@raman-m raman-m added this to the Summer'25 milestone May 27, 2025
@raman-m

raman-m commented Dec 27, 2025

Copy link
Copy Markdown
Member

Do you want me to take care of the merge conflicts in your pull request?

@coveralls

coveralls commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 97.12% (+0.004%) from 97.116% — rocleegithub:merge-conflicts into ThreeMammals:develop

@raman-m raman-m removed the conflicts Feature branch has merge conflicts label Dec 27, 2025
@twenzel

twenzel commented Mar 16, 2026

Copy link
Copy Markdown

@raman-m Any progress on this?

@raman-m

raman-m commented Mar 16, 2026

Copy link
Copy Markdown
Member

@twenzel wrote on March 16

You can see the progress yourself. The author has not been responsive since November 2024. I have done some work on this PR in his absence, particularly resolving all merge conflicts during 2025 for several major releases, to keep it updated and ready for potential code reviews.
However, if the author does not want to maintain the PR and prepare it for final review and merging, I cannot fully take over this responsibility on his behalf. I have many other responsibilities in the project.

Please ask the author, a Chinese developer, whether he still intends to make a proper contribution to the product, rather than leaving this pull request as a draft.

P.S. The approximate time when I may return to this PR is after the release of .NET 10, not earlier. The milestone must be closed.

@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.55%. Comparing base (d1f22d9) to head (e9225f3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2201   +/-   ##
========================================
  Coverage    95.55%   95.55%           
========================================
  Files          264      264           
  Lines         6970     6978    +8     
  Branches       761      761           
========================================
+ Hits          6660     6668    +8     
  Misses         201      201           
  Partials       109      109           
Flag Coverage Δ
unit 95.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Infrastructure/Placeholders.cs 93.10% <100.00%> (+0.69%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raman-m
raman-m force-pushed the develop branch 5 times, most recently from c2fb365 to a5efd3c Compare May 21, 2026 17:06
@raman-m
raman-m force-pushed the develop branch 5 times, most recently from 11ba99c to 78c983d Compare July 29, 2026 15:30
@raman-m raman-m added the Routing Ocelot feature: Routing label Sep 4, 2026
@raman-m
raman-m self-requested a review September 4, 2026 16:08
@raman-m raman-m added the high High priority label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Autumn'26 Autumn 2026 release high High priority Routing Ocelot feature: Routing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants