Change control cards for product versions - #46
Draft
ArtyomSavchenko wants to merge 11 commits into
Draft
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
marked this pull request as ready for review
July 27, 2026 02:45
aonnikov
reviewed
Jul 27, 2026
| export interface CardRelation extends Association { | ||
| purpose?: string | ||
| filter?: string | ||
| requireLatest?: boolean |
Collaborator
There was a problem hiding this comment.
Bad name and behavior choice. I suggest to use something applyToAnyVersion or matchAnyVersion which is enabled only when set to true
Collaborator
|
What is so specific about cards that we need a mixin for relations? |
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
marked this pull request as draft
July 27, 2026 03:31
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related TraceX ticket: https://app.tracex.co/workbench/tracex-ws/card/6a05cf2a6fdb770f2db24ea4
Adds the ability to attach cards as change control to product versions, on top of the
existing change-control document. Built as a general, reusable mechanism for linking any
class to cards with custom logic, then wired up for products.
General layer (reusable)
card.mixin.CardRelationmixin oncore.class.Association(purpose,filter,requireLatest) — lets any class link cards with a semantic purpose and an optionaleligibility filter, on top of the platform's generic relations.
RelationEditornow honors the mixin: candidate cards are narrowed by the association'scard type, the stored filter, and (unless disabled) the latest version.
filtersToQueryfromview-resourcesto re-apply stored view filters as a query.Products
per-type filter (creates purpose-marked associations).
in the "Create product version" dialog, restricted to the configured type + filter + latest.
one card must be attached (mirrors the existing change-control document requirement).