Repository navigation
Filter unsupported extreme starting valuations from market-cap sorting - #89
Draft
oniisanlabs wants to merge 1 commit into
Draft
oniisanlabs wants to merge 1 commit into
oniisanlabs wants to merge 1 commit into
Conversation
Assess lifetime outside volume and meaningful wallets before pagination, while keeping small launches visible without activity. Add an explicit all-valuations mode, exact spot-price ordering, request-local pricing, and SQL/API regression coverage.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Market-cap sorting is dominated by launches with enormous starting valuations and only dust trading. This adds a default browsing filter for those launches and makes the USD ordering use the same spot valuation that the list displays.
The filter applies only to
sort=mcap. Starting and current FDV must both be at least $10M; those launches need lifetime outside volume of at least 0.1% of starting FDV and at least three outside wallets with cumulative trading of $1 each. Creator trades, unattributed trades, and the launch block plus the next three blocks do not qualify. Both FDVs and wallet dollar amounts use the current quote/USD price. Small launches remain visible with no trades or holders.The list has an Include all valuations checkbox (
mcap=all), an explanation of the thresholds, and neutral “Limited outside trading” labels in the all-valuations view. Search, other sorts, watchlists and direct token links keep all launches. Filtering happens before pagination. Exact sqrt prices determine the ordering, tick is the fallback, unknown USD prices sort last, and very large values use scientific notation. List requests retain their own quote-price/metadata snapshot; list/live responses carry the selection and policy version so stale responses cannot restore the previous mode.No database migration, indexer change, contract change or new package is required. The query uses the existing chain/token swap index and only assesses lifetime trading for high starting/current valuations. CI now runs the actual SQL and API regression script against disposable PostgreSQL.
Validation:
Scope limitation: a coin that started below $10M can still reach a high spot valuation after dust trading and remain visible. That is intentional under the starting-and-current rule, which preserves launches that grow from small valuations. This filter is a browsing heuristic, not proof of liquidity, authenticity or independent wallet ownership.