fix: Plain text paste does not preserve line breaks#2702
fix: Plain text paste does not preserve line breaks#2702Gxrvish wants to merge 1 commit intoTypeCellOS:mainfrom
Conversation
|
@gppa-odoo is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@YousefED few remarks? |
| ], | ||
| "dependencies": { | ||
| "remark-breaks": "^4.0.0" | ||
| } |
There was a problem hiding this comment.
This is installed to the wrong package.json, it should be installed to the one in packages/core/package.json, this is a monorepo
| import { Schema } from "prosemirror-model"; | ||
| import remarkGfm from "remark-gfm"; | ||
| import remarkParse from "remark-parse"; | ||
| import remarkBreaks from "remark-breaks"; |
There was a problem hiding this comment.
Honestly, would prefer not to introduce a whole package just for this. And would like to have tests added that prove it does not break existing behavior
There was a problem hiding this comment.
Honestly, would prefer not to introduce a whole package just for this
For this operation adding a package is worth, Because doing it from scratch without the help of package might break some edge cases which may introduce unusual behaviour.
would like to have tests added that prove it does not break existing behavior
Will add it soon 🙂
Thanks for the review 😊 !!!
2 participants
Summary
This PR aims to solve an issue described here
Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes