ADBMS reversible isospi & command count#2118
Open
pranay-o wants to merge 5 commits into
Open
Conversation
pranay-o
commented
Jul 11, 2026
|
|
||
| uint8_t expected_count = 0U; | ||
| Segments<uint32_t> mismatch_counts{}; | ||
| io::semaphore command_count_lock { true }; |
Contributor
Author
There was a problem hiding this comment.
The way this lock is used is kinda stupid. easy to cause a deadlock with spi lock
pranay-o
commented
Jul 11, 2026
| mismatch_counts[seg]++; | ||
| return false; | ||
| } | ||
| return true; |
Contributor
Author
There was a problem hiding this comment.
idk if it should resync or reset. if i try to reset, it causes deadlock so keep this way or think of smth better
pranay-o
commented
Jul 11, 2026
| continue; | ||
| } | ||
|
|
||
| if (not commandCount::check(static_cast<uint8_t>(segment), segment_reg_group.cmd_count())) { |
Contributor
Author
There was a problem hiding this comment.
if i unplug the segment, bus will go high so would i expect 0x3F here?
Contributor
Author
There was a problem hiding this comment.
do I care if ts happens cuz this a different issue. it would keep on trying to correct it but it will always stay 0x3F so mismatch number will keep on increasing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.