Fido client patch and QoL update - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Patched some issues with the
EISClientfor SunPy's Fido and added a few quality-of-life improvements. Closes #120Updated EISClient Behavior
By default, the client only returns entries for the HDF5 data files and fetching a
data.h5file will automatically download the matchinghead.h5too. This change cuts the overall search time by 50 - 60%, eliminates duplicate entries, and ensures that users always download the files they need. Searching for and fetchinghead.h5files will only return and download the header files, should a user need or wish to do so. The old behavior of retuning a list of all files associated with each observation can produced by setting thea.eispac.FileType("any")search parameter.In general, the FITS files are really only useful to IDL users who wish to analyze the data using older IDL routines, since they contain the exact same data as the HDF5 files, but are missing some of the essential metadata that must be provided by the SSW routines. To our knowledge, no one was using the Fido client to download the FITS files. This is evidenced by the fact that the FITS level-1 data comes in pairs of "l1" (data) and "er" (errors) files generated by the "EIS_PREP" routine in SolarSoft/IDL and the old EISClient was actually only searching for and downloading the "er" files (a problem no one has mentioned or raised before). This issue has also been patched. Now, fetching a FITS entry will download both the "l1" and "er" files.