fix(15-11): cite pinned D-11 evidence copies for two structural rows - #28
Merged
Conversation
- D-11 mechanism (not one of the eleven sweep classes): these two rows make structural assertions with no runtime observable a real-machine dispatch can produce (the absence of a persistence mechanism, the documented defaults of a companion FEATURES.md) — each now cites a pinned copy under this repository's Phase 10 evidence root (checklist-copy/src@b30a910/BagLockService.java, checklist-copy/FEATURES.md@b30a910.md) with its SHA-256, rather than the live source tree, which could drift after this row's fixture was pinned - ultiremotebag.bag.lock-not-persisted: BagLockService.java pinned and hash-verified to still show the ConcurrentHashMap-only locks field with zero @Table/DataOperator/getOperator hits, matching the row's existing claim - ultiremotebag.config.remotebag-yml: FEATURES.md pinned at the same commit so the row's key-by-key default check reads a fixed document rather than whatever FEATURES.md happens to say when dispatched - non-weakening (D-12): neither row's assertion changes; only the citation target does - this repository's own sweep-class detectors (all eleven, re-run against this corrected file) found zero other candidates, consistent with 15-CORRECTION-INVENTORY.md's 'No sweep-class correction rows' finding for this repository Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018BUB3sHMAHm8bYVbLbTTKK
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9771c1253e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ference Addresses @codex review finding: ultiremotebag.bag.lock-not-persisted and .config.remotebag-yml reference pinned copies at checklist-copy/src@b30a910/ and checklist-copy/FEATURES.md@b30a910.md, but neither file existed in this commit tree, making both rows unexecutable as written. Both files are the exact git-show output at commit b30a910, with SHA-256 matching the hash already cited in each row (9bad4314.../deb72b62...), confirming no drift. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018BUB3sHMAHm8bYVbLbTTKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist-only correction pull request from Phase 15's class-swept
UAT-CHECKLIST.mdinventory(
15-CORRECTION-INVENTORY.md,15-SWEEP-CLASSES.md). No product source file changes. Thisrepository's own inventory section recorded "No sweep-class correction rows" across all eleven
classes — confirmed again by this session's own re-run of all eleven detectors, zero findings. One
commit, applying the D-11 pinned-copy mechanism (not one of the eleven sweep classes) to the two
rows the inventory cross-referenced:
ultiremotebag.bag.lock-not-persisted— a structural assertion (no persistence mechanismexists for the in-memory lock map) with no runtime observable a real-machine dispatch can produce
short of a genuine non-clean process kill against the shared server. Now cites a pinned copy of
BagLockService.javaat this repository's HEAD (checklist-copy/src@b30a910/BagLockService.java,SHA-256
9bad43143bc32658bf7a5a99200bdaf470b45a67081b5ec0bd4f6c12558ba95d) rather than the livesource tree, which could drift after this row's fixture was pinned. Hash-verified to still show
the
ConcurrentHashMap-onlylocksfield with zero@Table/DataOperator/getOperatorhits,matching the row's existing claim.
ultiremotebag.config.remotebag-yml— the row's key-by-key default check now reads a pinnedFEATURES.mdsnapshot (checklist-copy/FEATURES.md@b30a910.md, SHA-256deb72b62a5238af6fee03dbbe2006ea80521cbc2d1e426c186b0deb90eb5618c) rather than whateverFEATURES.mdhappens to say at dispatch time.Non-weakening (D-12): neither row's assertion changes; only the citation target does.
Verification
15-SWEEP-CLASSES.mdre-run against the corrected file:zero findings, matching this repository's own inventory section.
filereports the same line-ending style before and after.masterthroughout,git status --porcelain -- UAT-CHECKLIST.md FEATURES.mdempty at both ends — all editing happened in a dedicated worktree on this branch.the source/companion document they were copied from.
FEATURES.mdis unchanged in this pull request; recorded as a known deviation from this plan'sown generic verify assertion (which expects both documents in the diff) in the plan's SUMMARY
and ledger fragment.
Issue closure
None
Scope
Documentation-only (
UAT-CHECKLIST.md). This pull request is opened, not merged — merging waitsfor the real-machine gate that the dispatch executing these corrected rows closes.
🤖 Generated with Claude Code
https://claude.ai/code/session_018BUB3sHMAHm8bYVbLbTTKK