Avoid 308 - #30
Merged
Merged
Avoid 308 #30
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
Reviewed by Cursor Bugbot for commit c03b93c. Configure here.
urrsk
reviewed
Aug 5, 2026
urrsk
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Note
Low Risk
Small HTTP routing and socket timeout behavior changes in the external-control backend; no auth or data-model impact.
Overview
Flask GET route
/<port>/<robotIP>/now setsstrict_slashes=False, so requests with or without a trailing slash are handled directly instead of triggering a 308 redirect (fixes #26).RequestProgram.send_commandseparates connect vs receive timeouts: 5s forconnect, 1s perrecvwith a 5s overall receive budget. Failed connects still surface Connection timeout; stalled receives with no data now raise Timeout while receiving data. The unit test expectation was updated for that message.Reviewed by Cursor Bugbot for commit 714c146. Bugbot is set up for automated code reviews on this repo. Configure here.