Move all arguments out of macro file - #495
Conversation
This way it can be included more easily.
|
Would be even better if there would be a way to keep the It's really rather awkward having that present in all cases. The changes in this PR seem to also highlight that. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## foxy #495 +/- ##
======================================
Coverage ? 3.73%
======================================
Files ? 16
Lines ? 1071
Branches ? 212
======================================
Hits ? 40
Misses ? 942
Partials ? 89
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I do agree on the awkward part, but so far I couldn't come up with a satisfying solution. I've started #496 to share my concerns. Maybe we can discuss things there a bit to migrate to a proper solution? |
|
@RobertWilbrandt a review on this would be appreciated before we put Foxy to its EOL sleep. |
|
Closing this, since Foxy is no longer updated. |
This way it can be included more easily.
@p0rys this should fix the problems mentioned in #482.