Skip to content

Move all arguments out of macro file - #495

Closed
fmauch wants to merge 1 commit into
UniversalRobots:foxyfrom
fmauch:foxy_descr_includable
Closed

Move all arguments out of macro file#495
fmauch wants to merge 1 commit into
UniversalRobots:foxyfrom
fmauch:foxy_descr_includable

Conversation

@fmauch

@fmauch fmauch commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

This way it can be included more easily.

@p0rys this should fix the problems mentioned in #482.

This way it can be included more easily.
@gavanderhoorn

Copy link
Copy Markdown
Contributor

Would be even better if there would be a way to keep the ros2_control block out of the default macro completely.

It's really rather awkward having that present in all cases. The changes in this PR seem to also highlight that.

@codecov

codecov Bot commented Oct 5, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (foxy@e448b15). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             foxy    #495   +/-   ##
======================================
  Coverage        ?   3.73%           
======================================
  Files           ?      16           
  Lines           ?    1071           
  Branches        ?     212           
======================================
  Hits            ?      40           
  Misses          ?     942           
  Partials        ?      89           
Flag Coverage Δ
unittests 3.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fmauch

fmauch commented Oct 5, 2022

Copy link
Copy Markdown
Contributor Author

Would be even better if there would be a way to keep the ros2_control block out of the default macro completely.

It's really rather awkward having that present in all cases. The changes in this PR seem to also highlight that.

I do agree on the awkward part, but so far I couldn't come up with a satisfying solution. I've started #496 to share my concerns. Maybe we can discuss things there a bit to migrate to a proper solution?

@fmauch fmauch added the Foxy label Oct 5, 2022
@fmauch

fmauch commented May 9, 2023

Copy link
Copy Markdown
Contributor Author

@RobertWilbrandt a review on this would be appreciated before we put Foxy to its EOL sleep.

@fmauch

fmauch commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Closing this, since Foxy is no longer updated.

@fmauch fmauch closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants