Repository navigation
feat(tests): implement unit tests and DB mocking for Hub REST API - #33
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR addresses Issue #19 by introducing comprehensive unit tests for the SRE Hub REST API.
To ensure the CI tests can run quickly and securely without requiring a live PostgreSQL instance, we integrated
go-sqlmockto intercept and mock all database queries at thedatabase/sqllayer.✅ Changes Made
github.com/DATA-DOG/go-sqlmockto thesre-agent/hubmodule.NewWithDB(db *sql.DB)constructor ininternal/db/store.goto safely inject mocked connections without triggering schema migrations.internal/api/handlers_test.goutilizingnet/http/httptestto test our endpoints.🧪 Testing Scope
The new test suite fully covers the acceptance criteria defined in #19:
TestReceiveIncident_Valid: Verifies a201 Createdresponse when a valid incident payload is submitted and database expectations are met.TestReceiveIncident_InvalidJSON: Verifies a400 Bad Requesterror is returned when malformed JSON is posted.TestReceiveIncident_Unauthorized: Verifies a401 Unauthorizederror when theX-Claritty-Keyheader is missing.TestGetStats: Verifies that the metrics calculations return a200 OKJSON response.Fixes #19