Repository navigation
fix(client): keep the country module off the home page and restore readable subtopics and the powered by row - #419
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
withCountryscoped/too, so the header logo, the desktop and mobile Home links and the not-found page sent/{locale}/ECUusers to/{locale}/ECU, where the country module dialog and banner opened again.useSignOut's default/follows the same rule./{locale}/{CODE}(any case) redirects with a 307 to/{locale}, keeping the query string — a bookmarked or typed module home URL no longer reopens the module on the home page.CountryModuleis mounted only by the report tool layout — the(app)layout covers the home, auth and partners pages, where the module never applies, and was the only place the dialog and banner could show outside the report tool.text-sm font-medium— the uppercase, bold, letter-spaced 12px muted style from #413 made long lists hard to read.Test plan
CI
Client Unit TestsClient Integration TestsPlaywright E2E TestsDev, after merge (signed in, inside the Ecuador module at
/en/ECU/reports)/enwith no country module dialog and no banner/enwith no country module dialog and no banner/en/ECUor/es/ecu?x=1directly redirects to/en//es?x=1/en/ECU/reports, and moving between/en/ECU/reports,/reports/gridand/reports/indicatorskeeps/ECU/en/ECU/reports/en/ECU/reportslands on/en/auth/sign-inwith no country module dialog and no bannerDev, after merge (other pages)
/en/reports/indicators, expanding a topic shows its subtopic titles in sentence case, and long titles stay inside their row