Skip to content

fix(client): keep the country module off the home page and restore readable subtopics and the powered by row - #419

Merged
mitoperni merged 7 commits into
developfrom
fix/home-link-leaves-country-module
Oct 1, 2026
Merged

mitoperni merged 7 commits into
developfrom
fix/home-link-leaves-country-module

Conversation

@mitoperni

@mitoperni mitoperni commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Links to the home page no longer carry the active country module — withCountry scoped / too, so the header logo, the desktop and mobile Home links and the not-found page sent /{locale}/ECU users to /{locale}/ECU, where the country module dialog and banner opened again. useSignOut's default / follows the same rule.
  • /{locale}/{CODE} (any case) redirects with a 307 to /{locale}, keeping the query string — a bookmarked or typed module home URL no longer reopens the module on the home page.
  • CountryModule is mounted only by the report tool layout — the (app) layout covers the home, auth and partners pages, where the module never applies, and was the only place the dialog and banner could show outside the report tool.
  • Subtopic titles in the indicators list are back to text-sm font-medium — the uppercase, bold, letter-spaced 12px muted style from #413 made long lists hard to read.
  • The home partners section shows the "Powered by" row with Green Climate Fund under a divider again, reverting the single-grid layout from #416.

Test plan

CI

  • Client Unit Tests
  • Client Integration Tests
  • Playwright E2E Tests

Dev, after merge (signed in, inside the Ecuador module at /en/ECU/reports)

  • Clicking the header logo lands on /en with no country module dialog and no banner
  • Clicking Home in the burger menu lands on /en with no country module dialog and no banner
  • Opening /en/ECU or /es/ecu?x=1 directly redirects to /en / /es?x=1
  • "Report tool" in the header still links to /en/ECU/reports, and moving between /en/ECU/reports, /reports/grid and /reports/indicators keeps /ECU
  • The dialog and banner still show on /en/ECU/reports
  • Logging out from the header menu on /en/ECU/reports lands on /en/auth/sign-in with no country module dialog and no banner

Dev, after merge (other pages)

  • On /en/reports/indicators, expanding a topic shows its subtopic titles in sentence case, and long titles stay inside their row
  • The home partners section shows ACTO, IDB Atlas, Development Data Partnership, Esri and Vizzuality, a divider, then "Powered by" with Green Climate Fund

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
amazonia-360 Ready Ready Preview Oct 1, 2026 5:58pm UTC

Request Review

@mitoperni mitoperni changed the title fix(country): keep the country module off the home page fix(client): keep the country module off the home page and restore readable subtopics and the powered by row Oct 1, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@mitoperni
mitoperni merged commit 4530440 into develop Oct 1, 2026
15 checks passed
@mitoperni
mitoperni deleted the fix/home-link-leaves-country-module branch October 1, 2026 18:03

This branch was successfully deployed

1 active deployment
Preview — 900e4883 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant