Repository navigation
fix(client): use the module name in country module copy - #420
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
moduleNameKeyinstead ofnameKey—nameKeybecame the plain country name ("Ecuador") in #411, so the dialog lost "Ecuador Amazonia", and the edit-location note said "outside Ecuador" while coverage is measured against the Amazonia boundary only.Test plan
CI
Client Unit TestsClient Integration TestsPlaywright E2E TestsDev site after merge (en, es, pt)
/<locale>/ECU/reports/gridwith no area: dialog title is "Ecuador Amazonia" / "Amazonía Ecuatoriana" / "Amazônia Equatoriana" and the body names the module once per mention, with no repeated "Amazonia"/<locale>/reportssidebar description says "indicators catalog" / "catálogo de indicadores" and no longer mentions DataHub