Skip to content

fix(client): use the module name in country module copy - #420

Merged
mitoperni merged 2 commits into
developfrom
fix/country-module-name-copy
Oct 2, 2026
Merged

mitoperni merged 2 commits into
developfrom
fix/country-module-name-copy

Conversation

@mitoperni

Copy link
Copy Markdown
Collaborator

Summary

  • Country module dialog and edit-location note read moduleNameKey instead of nameKey — nameKey became the plain country name ("Ecuador") in #411, so the dialog lost "Ecuador Amazonia", and the edit-location note said "outside Ecuador" while coverage is measured against the Amazonia boundary only.
  • No-area dialog body drops "{name}'s Amazonia region" for "{name}" — with the module name it read "Ecuador Amazonia's Amazonia region" / "Amazonía de Amazonía Ecuatoriana".
  • es/pt gain the article before the module name in the no-area body, deactivation body and edit-location notes ("de la Amazonía Ecuatoriana", "da Amazônia Equatoriana") — all eight module names are feminine "Amazonía/Amazônia …".
  • Report sidebar copy says "browse the indicators catalog" instead of "browse the DataHub", in en/es/pt — DataHub is no longer the product name.

Test plan

CI

  • Client Unit Tests
  • Client Integration Tests
  • Playwright E2E Tests

Dev site after merge (en, es, pt)

  • /<locale>/ECU/reports/grid with no area: dialog title is "Ecuador Amazonia" / "Amazonía Ecuatoriana" / "Amazônia Equatoriana" and the body names the module once per mention, with no repeated "Amazonia"
  • Drawing an area inside Ecuador's Amazonia opens the dialog with "…sits within Ecuador Amazonia" / "dentro de la Amazonía Ecuatoriana" / "dentro da Amazônia Equatoriana"
  • Moving the area of a saved ECU report outside the module shows "outside Ecuador Amazonia" / "fuera de la Amazonía Ecuatoriana" / "fora da Amazônia Equatoriana" in the edit-location confirm dialog
  • Drawing an area outside the module shows the deactivation notice with "de la" / "da" before the module name in es/pt
  • /<locale>/reports sidebar description says "indicators catalog" / "catálogo de indicadores" and no longer mentions DataHub

@mitoperni mitoperni self-assigned this Oct 2, 2026
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
amazonia-360 Ready Ready Preview Oct 2, 2026 11:42am UTC

Request Review

@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2026

Copy link
Copy Markdown

@mitoperni
mitoperni merged commit e98dbbe into develop Oct 2, 2026
15 checks passed
@mitoperni
mitoperni deleted the fix/country-module-name-copy branch October 2, 2026 11:48

This branch was successfully deployed

1 active deployment
Preview — ef0239fe Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant