Skip to content

fix(client): keep existing preview accounts unchanged in the seed #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeh merged 1 commit into from
Oct 9, 2026
Merged

fix(client): keep existing preview accounts unchanged in the seed #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 8 additions & 25 deletions client/src/cms/seed/seed-preview-users.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,41 +56,24 @@ describe("seedPreviewUsers", () => {
}
});

test("resets the password of a row that exists and does not create it again", async () => {
const { payload, created, updated } = fakePayload({ admins: ["a@example.test"] });
test("leaves a row that exists unchanged and does not create it again", async () => {
const { payload, created, updated } = fakePayload({
admins: ["a@example.test"],
users: ["b@example.test"],
});

await seedPreviewUsers(payload, EMAILS, "new-secret");

expect(updated).toEqual([
expect.objectContaining({
collection: "admins",
id: "admins:a@example.test",
data: { password: "new-secret" },
}),
]);
expect(updated).toHaveLength(0);
expect(created.filter((call) => call.collection === "admins")).toHaveLength(2);
});

test("verifies an existing user again when it resets the password", async () => {
const { payload, updated } = fakePayload({ users: ["b@example.test"] });

await seedPreviewUsers(payload, EMAILS, "secret");

expect(updated).toEqual([
expect.objectContaining({
collection: "users",
id: "users:b@example.test",
data: { password: "secret", _verified: true },
}),
]);
expect(created.filter((call) => call.collection === "users")).toHaveLength(2);
});

test("looks up emails in lower case", async () => {
const { payload, created, updated } = fakePayload({ admins: ["a@example.test"] });
const { payload, created } = fakePayload({ admins: ["a@example.test"] });

await seedPreviewUsers(payload, ["A@Example.test"], "secret");

expect(updated).toHaveLength(1);
expect(created.filter((call) => call.collection === "admins")).toHaveLength(0);
});
});
7 changes: 3 additions & 4 deletions client/src/cms/seed/seed-preview-users.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ const upsertPreviewAccount = async (
depth: 0,
});

if (docs[0]) {
const data = collection === "users" ? { password, _verified: true } : { password };
await payload.update({ collection, id: docs[0].id, data });
} else if (collection === "users") {
if (docs[0]) return;

if (collection === "users") {
await payload.create({
collection,
data: { email, password, _verified: true },
Expand Down
Loading