fix(safe-json): parse negative BigInts#274
Open
bramcohen wants to merge 2 commits into
Open
Conversation
|
All contributors have signed the CTA ✍️ ✅ |
Author
|
I have read the CTA Document and I hereby sign the CTA |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes @walletconnect/safe-json so safeJsonParse correctly revives negative BigInt values that were serialized in the library’s custom string format (e.g. "-100n"), and adds a test to prevent regressions.
Changes:
- Update the BigInt reviver pattern in
safeJsonParseto accept an optional leading-. - Add a round-trip test covering negative BigInt serialization/parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| misc/safe-json/src/index.ts | Expands the BigInt reviver regex to recognize negative custom BigInt strings. |
| misc/safe-json/test/index.test.ts | Adds a unit test validating negative BigInt round-trip behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…maxint Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeJsonStringifyemits negative BigInts as"-100n", butsafeJsonParseonly matched/^\d+n$/, so negatives stayed strings.Change the reviver to
/^-?\d+n$/and add a round-trip test.Test plan
cd misc/safe-json && npm test(Node 24)