feat: Position target style presets (academic/research vs. industry)

[warnes]

Summary

Add a position target style concept that captures the fundamental differences between position types and drives defaults throughout the app — page length targets, content depth, formatting style, and emphasis.

Motivation

The current design uses fixed page-count thresholds (≤2 pages = green, etc.) and a single set of content-selection heuristics regardless of the kind of position being applied for. In practice, these differ significantly:

Dimension	Academic / Research / Medical	Industry / Corporate
Ideal CV length	3–10+ pages (comprehensive)	1–2 pages (concise)
Publications	Required, comprehensive	Omit or 2–3 highlights max
Teaching / service	Include	Omit
Bullet style	Full sentences, methodology detail	Impact-first, metric-driven
Summary	Research statement	3-line career summary
ATS emphasis	Journal names, grant agencies, methods	Keywords, tools, outcomes

Without a position type concept, the app either uses wrong defaults or forces the user to manually override many settings for every session.

Proposed approach

Define a position target style as a named preset (stored in config.yaml and overridable per-session) with the following fields:

position_styles:
  industry:
    label: "Industry / Corporate"
    page_target: 2          # pages; used for badge thresholds in settings bar
    page_warn_pct: 10       # amber when >10% over target
    page_error_pct: 25      # red when >25% over target
    include_publications: false
    include_teaching: false
    bullet_style: "impact"  # impact-first, metric-driven
    summary_style: "career" # 3-line career summary
    ats_mode: "keywords"

  academic:
    label: "Academic / Research"
    page_target: null       # no upper limit; no colour warning
    page_warn_pct: null
    page_error_pct: null
    include_publications: true
    include_teaching: true
    bullet_style: "detail"  # full methodology
    summary_style: "statement" # research/teaching statement
    ats_mode: "methods"

  medical_clinical:
    label: "Medical / Clinical"
    page_target: null
    include_publications: true
    include_teaching: true
    bullet_style: "clinical"
    summary_style: "statement"
    ats_mode: "clinical"

  government:
    label: "Government / Federal"
    page_target: null       # federal resumes often 4–6 pages
    bullet_style: "detail"
    summary_style: "career"
    ats_mode: "keywords"

The active position style would be:

1. Set during job intake (user selects or the LLM infers from the job description)
2. Overridable per-session in the settings bar
3. Used to set defaults for page-count badge thresholds, include/exclude suggestions, bullet rewrite tone, and summary style

UI integration points

• Job intake: Add "Position type" selector (dropdown or LLM-inferred with confirmation)
• Settings bar (§5 of redesign): Show active style: "Style: Industry ▾" with override dropdown
• Page count badge: Use page_target from the active style for threshold colours instead of fixed values
• LLM prompts: Pass position style as context to customisation and rewrite prompts
• Master CV tab: Allow per-section "include by default for [style]" flags

Out of scope for this issue

• Custom user-defined styles (future)
• Per-section style overrides (future)
• Style inference from job description (can be a separate issue)

Related

• tasks/ui-redesign-proposal.md §5 (page count badge now references this issue)
• config.yaml — where presets would be stored
• scripts/utils/cv_orchestrator.py — where include/exclude and rewrite logic lives

[warnes]

Amendment: Publication handling fields per position style

Each position style preset should include a publications block specifying how the publications section is selected, filtered, formatted, and labelled. Proposed fields:

position_styles:
  industry:
    publications:
      include: false              # omit section entirely
      max_count: 0
      heading: null

  academic:
    publications:
      include: true
      max_count: null             # no limit — include all
      selection: "all"            # all | most_recent | most_cited | most_relevant
      heading: "Publications"     # "Publications" when full list, "Selected Publications" when subset
      show_count_notation: false  # omit "(N of M)" notation (per design decision D7.4)
      types:                      # which publication types to include
        journal_articles: true
        book_chapters: true
        conference_proceedings: true
        preprints: true
        technical_reports: true
        patents: true
      include_metrics: true       # show citation counts, impact factor, h-index context
      format: "full"              # full | abbreviated | title_journal_only
      citation_style: "APA"       # APA | Vancouver | AMA | MLA | Chicago | field_default

  medical_clinical:
    publications:
      include: true
      max_count: null
      selection: "all"
      heading: "Publications"
      types:
        journal_articles: true
        book_chapters: true
        conference_proceedings: false   # typically omitted in clinical CVs
        preprints: false
        technical_reports: false
        patents: false
      include_metrics: false
      format: "full"
      citation_style: "Vancouver"       # standard in clinical/medical contexts

  government:
    publications:
    # federal resumes typically omit publications unless the role is research-facing
      include: false
      max_count: 0
      heading: null

Industry variant — "highlight mode"

For industry positions where a few high-impact publications strengthen the case (e.g. a data scientist role that values peer-reviewed ML work), add a sub-preset or allow override:

  industry_research:
    label: "Industry / Research-facing"
    publications:
      include: true
      max_count: 3                # highlight only
      selection: "most_relevant"  # LLM selects most relevant to job
      heading: "Selected Publications"
      types:
        journal_articles: true
        conference_proceedings: true
        preprints: false
        book_chapters: false
      include_metrics: false
      format: "abbreviated"       # title, venue, year only — no full citation
      citation_style: "APA"

Integration points

• LLM customisation prompt: Pass publications config so the model knows whether to include pubs and how many to surface
• cv_orchestrator.py _select_publications(): Use max_count, selection, and types to filter the publication list from Master CV
• cv-template.html: Use heading field to drive the "Publications" vs "Selected Publications" heading (already conditional per commit ad9edf0; extend to consume this config)
• Master CV tab: Allow per-publication tagging of type (journal, chapter, preprint, etc.) so the type filter above can work
• ATS validation: If include: false and the job analysis identifies publications as a hard requirement, surface a warning: "This position style omits publications but the job description mentions peer-reviewed work."

[warnes]

Partial implementation landed in commit c658590:

• _page_warning() in generation_routes.py is now domain-aware: academic/research roles (matching the existing _RESEARCH_DOMAIN_TERMS set) get only a too-short warning — no upper-page-limit — while industry roles keep the 2–3 page threshold.
• /api/estimate-pages now returns domain and page_length_warning fields.
• The pre-generation page estimate banner in the Layout Review tab shows role-appropriate copy: "academic/research CVs have no upper page limit" vs "industry target is 2–3 pages".

Remaining from the full proposal: per-session position style override UI, config.yaml preset storage, style-aware LLM prompt context, master CV per-section include flags. Those are larger changes that can be tracked separately.

[warnes]

Status update & remaining-scope split (triage)

Verified against current devel code — more of this landed than the previous comment indicated.

Already implemented

• Position-style presets — scripts/utils/config.py: _DEFAULT_POSITION_STYLES (industry / academic / government), position_styles merge property, get_position_style_for_domain(domain) domain-term matching (falls back to industry).
• Domain-aware page warnings — generation_routes.py _page_warning + /api/estimate-pages return domain / page_length_warning; Layout Review banner shows role-appropriate copy (commit c658590).
• Style-aware LLM prompt context — llm_client.py _POSITION_STYLE_CONTEXT_MSGS + _position_style_context(domain), injected into write/rewrite prompts.
• Publications default by style — cv_orchestrator.py suppresses the publications section by default when the active style has include_publications: false, honouring a per-session position_style_override.
• Per-session override UI — Layout Review page-estimate banner picker → POST /api/session/position-style (review_routes.py) → position_style_override in session state, consumed downstream.

Remaining scope (split into sub-issues)

• feat: config.yaml position-style preset overrides with medical_clinical + industry_research #131 — config.yaml position-style overrides + medical_clinical / industry_research presets (engine exists; config block + extra presets missing).
• feat: master CV per-section 'include by default' flags driven by position style #132 — Master CV per-section "include by default" flags keyed by style (+ publications sub-behaviour from the amendment).
• feat: job-intake position-type selector (LLM-inferred with confirmation) #133 — Job-intake "Position type" selector with LLM-inferred suggestion + confirmation (style currently inferred at layout time, not set at intake).

Keeping this issue open as the parent; sub-issues track the concrete remaining work.