Wt custom video player plugin by Atsumi3 · Pull Request #4 · WinTicket/packages

Atsumi3 · 2025-08-07T01:35:49Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

Copilot

Pull Request Overview

This PR adds a custom video player plugin with buffer configuration capabilities and enhanced status methods. The changes introduce buffer management features and additional playback state retrieval functionality across iOS and Android platforms.

Key Changes:

Adds Buffer class to configure video buffer settings (min/max buffer durations, playback thresholds)
Implements getDuration() and getIsPlaying() methods for real-time status retrieval
Updates Pigeon API definitions and generated code for both iOS and Android platforms

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
video_player_platform_interface.dart	Adds buffer configuration classes and new platform interface methods
video_player.dart	Integrates buffer configuration into VideoPlayerController and adds duration/isPlaying getters
Android implementation files	Implements buffer controls using ExoPlayer LoadControl and new API methods
iOS implementation files	Implements buffer controls using AVPlayer preferredForwardBufferDuration
Pigeon message files	Adds BufferMessage class and new API method definitions
Generated files	Updates from Pigeon code generation for new APIs

Copilot · 2025-08-07T01:38:43Z

+  }
+}
+
+/// バッファを調整するための各パラメーター


Comment contains Japanese text. Documentation should be in English for consistency with the rest of the codebase.

Suggested change

/// バッファを調整するための各パラメーター

/// Parameters for adjusting the buffer.

Copilot · 2025-08-07T01:38:43Z

+/// バッファを調整するための各パラメーター
+/// 以下4つはAndroidで使うもの
+/// iOSは[maxBufferMs]のみ使う


Comment contains Japanese text. Documentation should be in English for consistency with the rest of the codebase.

Suggested change

/// バッファを調整するための各パラメーター

/// 以下4つはAndroidで使うもの

/// iOSは[maxBufferMs]のみ使う

/// Parameters for adjusting the buffer.

/// The following four parameters are used on Android.

/// On iOS, only [maxBufferMs] is used.

Copilot · 2025-08-07T01:38:43Z

+/// バッファを調整するための各パラメーター
+/// 以下4つはAndroidで使うもの
+/// iOSは[maxBufferMs]のみ使う


Comment contains Japanese text. Documentation should be in English for consistency with the rest of the codebase.

Suggested change

/// バッファを調整するための各パラメーター

/// 以下4つはAndroidで使うもの

/// iOSは[maxBufferMs]のみ使う

/// Parameters for adjusting the buffer.

/// The following four are used on Android.

/// On iOS, only [maxBufferMs] is used.

Copilot · 2025-08-07T01:38:44Z

+  /// AndroidとiOSでバッファの値を調整するためにセットします
+  /// nullの場合は各プラットフォームのPlayerのデフォルトの値が使われます


Comment contains Japanese text. Documentation should be in English for consistency with the rest of the codebase.

Suggested change

/// AndroidとiOSでバッファの値を調整するためにセットします

/// nullの場合は各プラットフォームのPlayerのデフォルトの値が使われます

/// Set this to adjust the buffer values on Android and iOS.

/// If null, the default buffer values of each platform's player will be used.

Copilot · 2025-08-07T01:38:44Z

+  /// AndroidとiOSでバッファの値を調整するためにセットします
+  /// nullの場合は各プラットフォームのPlayerのデフォルトの値が使われます


Comment contains Japanese text. Documentation should be in English for consistency with the rest of the codebase.

Suggested change

/// AndroidとiOSでバッファの値を調整するためにセットします

/// nullの場合は各プラットフォームのPlayerのデフォルトの値が使われます

/// Set this to adjust buffer values on Android and iOS.

/// If null, the default value of each platform's player will be used.

Copilot · 2025-08-07T01:38:47Z

  }

+  @override
+  Future<void> setBuffer(int textureId, Buffer buffer) {


Missing implementation for getIsPlaying method. The interface defines this method but it's not implemented in this class.

Copilot · 2025-08-07T01:38:47Z

+
+    // Re-create the player with new buffer settings
+    ExoPlayerState currentState = ExoPlayerState.save(exoPlayer);
+    exoPlayer.release();
+    exoPlayer = createVideoPlayer();
+    currentState.restore(exoPlayer);


The setBuffer method recreates the entire ExoPlayer instance which may cause playback interruption. Consider if there's a way to update buffer settings without full recreation.

Suggested change

// Re-create the player with new buffer settings

ExoPlayerState currentState = ExoPlayerState.save(exoPlayer);

exoPlayer.release();

exoPlayer = createVideoPlayer();

currentState.restore(exoPlayer);

// Update the LoadControl on the existing player to apply new buffer settings

DefaultLoadControl.Builder builder = new DefaultLoadControl.Builder();

if (buffer != null) {

builder

.setBufferDurationsMs(

buffer.getMinBufferMs(),

buffer.getMaxBufferMs(),

buffer.getBufferForPlaybackMs(),

buffer.getBufferForPlaybackAfterRebufferMs());

}

exoPlayer.setLoadControl(builder.build());

Copilot · 2025-08-07T01:38:48Z

  flutter:
    sdk: flutter
-  video_player_platform_interface: ">=6.1.0 <7.0.0"
+  video_player_platform_interface: any


Using 'any' for dependency version is not recommended as it can lead to version conflicts. Use a specific version range instead.

Suggested change

video_player_platform_interface: any

video_player_platform_interface: ^6.2.2

Copilot · 2025-08-07T01:38:48Z

+dependency_overrides:
+  video_player_platform_interface:
+      git:
+        url: https://github.com/WinTicket/packages.git
+        path: packages/video_player/video_player_platform_interface
+        ref: 38856189efe8dece386b8968edadd98d61e0db63



Using dependency_overrides with external git repositories in production code can lead to maintenance issues and should be avoided.

Suggested change

dependency_overrides:

video_player_platform_interface:

git:

url: https://github.com/WinTicket/packages.git

path: packages/video_player/video_player_platform_interface

ref: 38856189efe8dece386b8968edadd98d61e0db63

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

FujiKinaga · 2025-08-15T05:15:56Z

+    buffer.bufferForPlaybackAfterRebufferMs = (msg.getBufferForPlaybackAfterRebufferMs() == null)
+            ? DefaultLoadControl.DEFAULT_BUFFER_FOR_PLAYBACK_AFTER_REBUFFER_MS
+            : toIntExact(msg.getBufferForPlaybackAfterRebufferMs());
+    player.setBuffer(buffer);


これも options にセットがいいかもです？

FujiKinaga · 2025-08-15T05:32:46Z

  Future<Duration> getPosition(int textureId) async {
    final int position = await _api.getPosition(textureId);
-    return Duration(milliseconds: position);
+    final int startResponse = await _api.start(textureId);


start呼んじゃってるかもです？

Atsumi3 added 8 commits July 30, 2025 19:18

java以外をmigrate

2ad765d

migrate java source

88c68de

update video_player_platform_interface ref

4ed4891

video_player, avfoundation のマイグレーション

8181865

minor fix android

086a930

impl setBuffer

80d0e2e

fix setBuffer

83c7cd0

impl android getDuration

d154f3b

Copilot AI review requested due to automatic review settings August 7, 2025 01:35

Copilot AI reviewed Aug 7, 2025

View reviewed changes

Atsumi3 and others added 4 commits August 14, 2025 18:27

fix unimplemented error

5b11351

Update pubspec.yaml

e0cbb67

Apply suggestions from code review

76fa99c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestions from code review

e032ea4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

FujiKinaga reviewed Aug 15, 2025

View reviewed changes

Atsumi3 added 2 commits August 15, 2025 14:24

Update pubspec.yaml

b6f2b4a

fix setBuffer cal

8ca75b6

FujiKinaga reviewed Aug 15, 2025

View reviewed changes

fix minor

699a41a

Navigation Menu

Uh oh!

Wt custom video player plugin - #4

Wt custom video player plugin#4
Atsumi3 wants to merge 15 commits into
mainfrom
wt-custom-video_player_plugin

Atsumi3 commented Aug 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

Copilot AI Aug 7, 2025

Uh oh!

FujiKinaga Aug 15, 2025

Uh oh!

FujiKinaga Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/// バッファを調整するための各パラメーター
	/// Parameters for adjusting the buffer.

		/// AndroidとiOSでバッファの値を調整するためにセットします
		/// nullの場合は各プラットフォームのPlayerのデフォルトの値が使われます

-    // Re-create the player with new buffer settings
-    ExoPlayerState currentState = ExoPlayerState.save(exoPlayer);
-    exoPlayer.release();
-    exoPlayer = createVideoPlayer();
-    currentState.restore(exoPlayer);
+    // Update the LoadControl on the existing player to apply new buffer settings
+    DefaultLoadControl.Builder builder = new DefaultLoadControl.Builder();
+    if (buffer != null) {
+      builder
+          .setBufferDurationsMs(
+              buffer.getMinBufferMs(),
+              buffer.getMaxBufferMs(),
+              buffer.getBufferForPlaybackMs(),
+              buffer.getBufferForPlaybackAfterRebufferMs());
+    }
+    exoPlayer.setLoadControl(builder.build());

	video_player_platform_interface: any
	video_player_platform_interface: ^6.2.2

Uh oh!

Conversation

Atsumi3 commented Aug 7, 2025

Pre-Review Checklist

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

FujiKinaga Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

FujiKinaga Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants