feat(audit): restore a11y as audit --check a11y (closes #256)#260
Merged
Conversation
Engine a11y_engine.py was orphaned by the #195 umbrella consolidation (same situation as css-deep #251 and export-snapshot #218). This restores access as audit --check a11y — thin wrapper commands/a11y.py, registered in audit._CHECKS, severity+category passthrough. Command count stays 12. Verified end-to-end: 2 real findings on tests/fixtures/sample.html, test_command_registry.py 2 passed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a11y_engine.pywas orphaned by the refactor(commands): consolidate 78 commands → 12 focused commands #195 umbrella consolidation (same as css-deep feat(audit): restore css-deep as audit --check css (orphaned engine since #195) #251, export-snapshot chore(deps): import-snapshot permanently broken since export-snapshot was dropped #218)audit --check a11yvia thin wrappercommands/a11y.py--severityand--categorypassthrough to engine; command count stays 12Patch Peta
scripts/commands/a11y.py(new) — thin wrapper overa11y_engine.audit_accessibility()scripts/commands/audit.py—a11yregistered in_CHECKS, namespace branch added, epilog updatedtests/test_command_registry.py—a11yadded to implementation-module allowlistdocs/design/0256-restore-a11y.md(new) — design docTesting
codelens audit tests --check a11y→ 2 findings (missing_label high + semantic_html low) from real fixturetest_command_registry.py2 passed--severity highpassthrough verifiedCloses #256