Repository navigation
feat: add a presence-api.keepalive filter so a push transport can hold a tab's rows - #904
Merged
Merged
Conversation
…n, not each tab's
Contributor
🚩 New public surface
|
Contributor
🛝 WordPress PlaygroundsBuilt from b98337b
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=========================================
Coverage 97.52% 97.52%
Complexity 269 269
=========================================
Files 30 30
Lines 4399 4403 +4
=========================================
+ Hits 4290 4294 +4
Misses 109 109
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
josephfusco
marked this pull request as ready for review
October 27, 2026 23:06
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With keepalive off the transport owns
user-{id}andeditor-{id}outright, so one that removes them per tab instead of per person takes the user offline, and the editor row'slockedflag, which nothing in this plugin reads, stops following core's lock.Related: #901
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with the implementation, tests and README entry.