Repository navigation
fix: keep the admin bar's presence menu current while it is open - #914
Draft
jaredrethman wants to merge 1 commit into
Draft
jaredrethman wants to merge 1 commit into
jaredrethman wants to merge 1 commit into
Conversation
Contributor
🛝 WordPress PlaygroundsBuilt from 5039e42
|
jaredrethman
force-pushed
the
fix/apply-refused-fragment-on-leave
branch
from
October 29, 2026 14:13
271281a to
4741663
Compare
jaredrethman
changed the title
jaredrethman
force-pushed
the
fix/apply-refused-fragment-on-leave
branch
from
October 29, 2026 22:43
4741663 to
b8da751
Compare
jaredrethman
force-pushed
the
fix/apply-refused-fragment-on-leave
branch
from
October 29, 2026 22:57
b8da751 to
5039e42
Compare
jaredrethman
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A swap refused while the admin bar menu was open waited for the next tick, which Heartbeat's cadence hid and a push transport shows as a stale menu. The admin bar keeps its list item on a swap anyway, so the swap now keeps the menu open and waits only for focus inside it, and a surface registered through
presence-api.liveSurfacesmay bring its ownbusy()check.Related: #901
Example consumer for a capable relay: https://github.com/wpsignal/wordsocket/pull/19/changes
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Fable 5.1
Used for: Tests from my findings, reviewed and tested by me, code review.