xls-66: fix equation (23) to include managementFee_overpayment#495
Open
Tapanito wants to merge 2 commits into
Open
xls-66: fix equation (23) to include managementFee_overpayment#495Tapanito wants to merge 2 commits into
Tapanito wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Problem
Equation (23) stated:
This is incorrect.
overpaymentInterest_netis the vault's share of the overpayment interest — the management fee has been netted out of it (formula 21), but the management fee is still a real cash outflow that leaves the overpayment amount and goes to the broker. The original formula effectively leaked the management fee into the principal reduction, overstating it.The accompanying note ("The management fee has already been deducted from
overpaymentInterest_net, so it does not appear as a separate term") compounded the error by providing a justification for the wrong formula.Fix
The correct money conservation identity is:
Substituting formula (21) confirms this reduces to
principalPortion = overpaymentAmount - overpaymentInterest_gross - overpaymentFee— no double subtraction. Equation (23) is updated accordingly and the incorrect note is removed.This is already consistent with Appendix A-3.2.3 and the
rippledimplementation inLendingHelpers.cpp:.trackedPrincipalDelta = overpayment - roundedOverpaymentInterest - roundedOverpaymentManagementFee - overpaymentFee,Context of Change
Type of Change