Skip to content

feat: Make VaultID conditional on LoanBrokerSet#6528

Open
Tapanito wants to merge 10 commits into
tapanito/lending-fix-amendmentfrom
tapanito/loan-broker-set
Open

feat: Make VaultID conditional on LoanBrokerSet#6528
Tapanito wants to merge 10 commits into
tapanito/lending-fix-amendmentfrom
tapanito/loan-broker-set

Merge branch 'tapanito/lending-fix-amendment' into tapanito/loan-brok…

64c7ff9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 8, 2026 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

❌ Patch coverage is 93.82716% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (tapanito/lending-fix-amendment@189f2d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...c/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp 93.4% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##             tapanito/lending-fix-amendment   #6528   +/-   ##
================================================================
  Coverage                                  ?   82.4%           
================================================================
  Files                                     ?    1011           
  Lines                                     ?   76974           
  Branches                                  ?    8966           
================================================================
  Hits                                      ?   63403           
  Misses                                    ?   13562           
  Partials                                  ?       9           
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
...xrpl/protocol_autogen/transactions/LoanBrokerSet.h 100.0% <100.0%> (ø)
...c/libxrpl/tx/transactors/lending/LoanBrokerSet.cpp 96.5% <93.4%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.