feat: Support XLS-39 Clawback amendment in xrpl-rust#163
Merged
Conversation
Collaborator
Author
|
/ai-review |
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 84.33% 84.49% +0.16%
==========================================
Files 226 227 +1
Lines 23958 24245 +287
==========================================
+ Hits 20205 20487 +282
- Misses 3753 3758 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Adds unit tests for the previously-uncovered positional constructor, the with_holder builder, and the Transaction trait getters, lifting clawback.rs patch coverage above the 80% codecov gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Parse both sides with from_str so the assertion is order-independent, instead of comparing JSON text wrapped in Value::String. Addresses review feedback on PR XRPLF#163. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Patel-Raj11
approved these changes
Jun 22, 2026
cybele-ripple
approved these changes
Jun 23, 2026
Collaborator
Author
|
thanks for the quick reviews @cybele-ripple @Patel-Raj11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds support for the Clawback amendment in xrpl-rust library.
The XLS specification can be found here: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0039-clawback
The rippled C++ PR implementation is here: XRPLF/rippled#4553
This PR adds only one transaction
Clawback. The included integration tests also validate the correctness ofAccountInfoRPC after the setting of thelsfAllowTrustLineClawbackflag.Type of Change
Before / After
Test Plan
Appropriate tests have been included.